Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid docker mounting to support CLI commands inside of a docker container #1370

Merged
merged 16 commits into from
Sep 23, 2020
Merged

Avoid docker mounting to support CLI commands inside of a docker container #1370

merged 16 commits into from
Sep 23, 2020

Conversation

deliahu
Copy link
Member

@deliahu deliahu commented Sep 21, 2020

closes #1361, closes #1325

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)

@deliahu deliahu changed the title Docker mount Avoid docker mounting to enable running CLI commands inside of a docker container Sep 21, 2020
@deliahu deliahu changed the title Avoid docker mounting to enable running CLI commands inside of a docker container Avoid docker mounting to support CLI commands inside of a docker container Sep 21, 2020
vishalbollu
vishalbollu reviewed Sep 22, 2020
View reviewed changes
vishalbollu
vishalbollu reviewed Sep 22, 2020
View reviewed changes
Copy link
Contributor

@vishalbollu vishalbollu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if you want to talk about the comments

@deliahu deliahu merged commit e31847f into master Sep 23, 2020
@deliahu deliahu deleted the docker-mount branch September 23, 2020 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishalbollu vishalbollu vishalbollu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refreshCachedClusterConfig() can return a cluster config with nil region Using cortex inside a docker
2 participants
@deliahu @vishalbollu