Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support AWS tags with spaces and valid special characters #1374

Merged
merged 4 commits into from
Sep 23, 2020
Merged

Support AWS tags with spaces and valid special characters #1374

merged 4 commits into from
Sep 23, 2020

Conversation

deliahu
Copy link
Member

@deliahu deliahu commented Sep 23, 2020

closes #1373

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)

@deliahu deliahu requested a review from vishalbollu September 23, 2020 00:12
vishalbollu
vishalbollu approved these changes Sep 23, 2020
View reviewed changes
@deliahu deliahu merged commit 5a8c4f7 into master Sep 23, 2020
@deliahu deliahu deleted the tag-improvements branch September 23, 2020 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishalbollu vishalbollu vishalbollu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support AWS tags with spaces and valid special characters
2 participants
@deliahu @vishalbollu