Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bypass instance limit check if AWS's API doesn't provide the information #1439

Merged
merged 3 commits into from
Oct 14, 2020
Merged

Bypass instance limit check if AWS's API doesn't provide the information #1439

merged 3 commits into from
Oct 14, 2020

Conversation

deliahu
Copy link
Member

@deliahu deliahu commented Oct 13, 2020

closes #1438

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)

@deliahu
Copy link
Member Author

deliahu commented Oct 13, 2020

Note: I confirmed that in regions where the list-service-quotas API is fully supported, there is an entry for instance types for which the user has zero quota

RobertLucian
RobertLucian approved these changes Oct 13, 2020
View reviewed changes
Copy link
Member

@RobertLucian RobertLucian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@deliahu deliahu merged commit e01a9be into master Oct 14, 2020
@deliahu deliahu deleted the limit-check branch October 14, 2020 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishalbollu vishalbollu vishalbollu approved these changes

@RobertLucian RobertLucian RobertLucian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

instance_type: you don't have access to t3.medium instances in eu-north-1 - error when deploying
3 participants
@deliahu @vishalbollu @RobertLucian