Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure log group is created when multiple prefixes exist for the BatchAPI kind #1468

Merged
merged 4 commits into from
Oct 19, 2020

Conversation

RobertLucian
Copy link
Member

@RobertLucian RobertLucian commented Oct 19, 2020

When a batch API is created, if the log group name is a prefix of another existing log group (that's longer in size), then while it's deploying, the log group name for our API won't get created.


checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)

@RobertLucian RobertLucian added the bug Something isn't working label Oct 19, 2020
@RobertLucian RobertLucian merged commit fcf39e6 into master Oct 19, 2020
@RobertLucian RobertLucian deleted the fix/batch-api-prefix-log-group branch October 19, 2020 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants