Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept class definition from Python Client directly #1587

Merged
merged 12 commits into from
Nov 24, 2020
Merged

Conversation

vishalbollu
Copy link
Contributor

@vishalbollu vishalbollu commented Nov 23, 2020

Closes #1617


checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)
  • update examples
  • update docs and add any new files to summary.md (view in gitbook after merging)
  • cherry-pick into release branches if applicable
  • alert the dev team if the dev environment changed

Copy link
Member

@RobertLucian RobertLucian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments here. Let me know if you want to discuss.

@vishalbollu vishalbollu merged commit 009863c into master Nov 24, 2020
@vishalbollu vishalbollu deleted the python-client branch November 24, 2020 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support deploying predictor Python classes from Python client
3 participants