Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminate container when bootloader script fails #1639

Merged
merged 3 commits into from
Dec 1, 2020
Merged

Terminate container when bootloader script fails #1639

merged 3 commits into from
Dec 1, 2020

Conversation

vishalbollu
Copy link
Contributor

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)
  • update examples
  • update docs and add any new files to summary.md (view in gitbook after merging)
  • cherry-pick into release branches if applicable
  • alert the dev team if the dev environment changed

deliahu
deliahu reviewed Nov 28, 2020
View reviewed changes
RobertLucian
RobertLucian reviewed Nov 28, 2020
View reviewed changes
Copy link
Member

@RobertLucian RobertLucian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool catch!

@RobertLucian RobertLucian mentioned this pull request Nov 28, 2020
Merged
6 tasks
@vishalbollu vishalbollu merged commit cdd67e7 into master Dec 1, 2020
@vishalbollu vishalbollu deleted the terminate-if-bootloader-fails branch December 1, 2020 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deliahu deliahu deliahu approved these changes

@RobertLucian RobertLucian RobertLucian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vishalbollu @deliahu @RobertLucian