Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python predictor server-side batching #1653

Merged
merged 13 commits into from
Dec 17, 2020
Merged

Conversation

miguelvr
Copy link
Collaborator

@miguelvr miguelvr commented Dec 4, 2020

closes #1382, closes #1470

Server side batching implementation for the python predictor types

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)
  • update examples
  • update docs and add any new files to summary.md (view in gitbook after merging)
  • cherry-pick into release branches if applicable
  • alert the dev team if the dev environment changed

@CLAassistant
Copy link

CLAassistant commented Dec 4, 2020

CLA assistant check
All committers have signed the CLA.

@miguelvr miguelvr marked this pull request as ready for review December 7, 2020 13:29
@miguelvr miguelvr force-pushed the feature/server-side-batching branch 2 times, most recently from a3a3eb6 to e4adfb3 Compare December 8, 2020 10:12
@miguelvr miguelvr requested a review from vishalbollu December 13, 2020 18:25
@miguelvr miguelvr force-pushed the feature/server-side-batching branch from 153e398 to d0d2b20 Compare December 13, 2020 18:27
@miguelvr miguelvr requested a review from vishalbollu December 17, 2020 10:48
@miguelvr
Copy link
Collaborator Author

@vishalbollu addressed your comments and tested again.

let's sync live regarding the opening of the issue to investigate performance

@miguelvr miguelvr merged commit 7d875d8 into master Dec 17, 2020
@miguelvr miguelvr deleted the feature/server-side-batching branch December 17, 2020 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants