Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic fixes #1667

Merged
merged 2 commits into from
Dec 8, 2020
Merged

Generic fixes #1667

merged 2 commits into from
Dec 8, 2020

Conversation

RobertLucian
Copy link
Member

@RobertLucian RobertLucian commented Dec 8, 2020 •
edited
Loading

  1. Layout bug: when the predictor.model_path field is specified for the TensorFlow predictor with the LR enabled, doing a cortex get would list the _cortex_default model instead of hiding it.
  2. If a "/" would be present at the beginning/end of a model path as specified with the predictor.models.dir field, the cortex deploy would then fail.
  3. When calling the client.stream_api_logs method for a GCP environment, the output message wasn't very clear.

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)

@RobertLucian RobertLucian added the bug Something isn't working label Dec 8, 2020
@RobertLucian RobertLucian requested a review from deliahu December 8, 2020 19:13
@RobertLucian RobertLucian self-assigned this Dec 8, 2020
@deliahu deliahu merged commit 22e2f49 into master Dec 8, 2020
@deliahu deliahu deleted the fix/generic-fixes branch December 8, 2020 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deliahu deliahu deliahu approved these changes

Assignees

@RobertLucian RobertLucian

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobertLucian @deliahu