Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support installing cortex pkg in API & aggregate internal modules into a pkg #1709

Merged
merged 16 commits into from
Dec 21, 2020
Merged

Support installing cortex pkg in API & aggregate internal modules into a pkg #1709

merged 16 commits into from
Dec 21, 2020

Conversation

RobertLucian
Copy link
Member

@RobertLucian RobertLucian commented Dec 17, 2020 •
edited
Loading

Closes #1670, closes #1206.

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)

deliahu
deliahu reviewed Dec 17, 2020
View reviewed changes
@RobertLucian RobertLucian removed the request for review from vishalbollu December 18, 2020 16:26
deliahu
deliahu approved these changes Dec 18, 2020
View reviewed changes
@RobertLucian RobertLucian merged commit e22985f into master Dec 21, 2020
@RobertLucian RobertLucian deleted the fix/cortex-pkg-in-api branch December 21, 2020 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelvr miguelvr miguelvr left review comments

@deliahu deliahu deliahu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@RobertLucian @deliahu @miguelvr