Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix number of API replicas shown in cortex cluster info cmd #2140

Merged
merged 10 commits into from
May 10, 2021
Merged

Fix number of API replicas shown in cortex cluster info cmd #2140

merged 10 commits into from
May 10, 2021

Conversation

RobertLucian
Copy link
Member

@RobertLucian RobertLucian commented May 4, 2021 •
edited
Loading

Fixes #2129.

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)

@RobertLucian RobertLucian requested a review from deliahu May 4, 2021 21:47
@RobertLucian
Copy link
Member Author

Add another column to what cortex cluster info outputs: async gateways. Hide it if there are no async APIs in the cluster.

miguelvr
miguelvr approved these changes May 5, 2021
View reviewed changes
Copy link
Collaborator

@miguelvr miguelvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one comment, but otherwise LGTM

@RobertLucian RobertLucian merged commit 3b7168c into master May 10, 2021
@RobertLucian RobertLucian deleted the fix/async-api-counting branch May 10, 2021 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelvr miguelvr miguelvr approved these changes

@deliahu deliahu Awaiting requested review from deliahu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cortex cluster info displays wrong number of AsyncAPIs
2 participants
@RobertLucian @miguelvr