Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 405 status code for un-implemented methods for the Realtime API #2158

Merged
merged 4 commits into from
May 10, 2021
Merged

Use 405 status code for un-implemented methods for the Realtime API #2158

merged 4 commits into from
May 10, 2021

Conversation

RobertLucian
Copy link
Member

@RobertLucian RobertLucian commented May 10, 2021 •
edited
Loading

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)

@RobertLucian RobertLucian added the ux User experience label May 10, 2021
@RobertLucian RobertLucian requested a review from deliahu May 10, 2021 15:37
miguelvr
miguelvr approved these changes May 10, 2021
View reviewed changes
@RobertLucian RobertLucian merged commit fb73a2b into master May 10, 2021
@RobertLucian RobertLucian deleted the fix/appropriate-status-code branch May 10, 2021 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deliahu deliahu deliahu approved these changes

@miguelvr miguelvr miguelvr approved these changes

Assignees
No one assigned
Labels
ux User experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RobertLucian @deliahu @miguelvr