Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve batch job submit validation efficiency #2179

Merged
merged 4 commits into from
May 22, 2021
Merged

Improve batch job submit validation efficiency #2179

merged 4 commits into from
May 22, 2021

Conversation

deliahu
Copy link
Member

@deliahu deliahu commented May 19, 2021

closes #2178

@deliahu deliahu requested a review from miguelvr May 19, 2021 22:38
miguelvr
miguelvr reviewed May 20, 2021
View reviewed changes
Copy link
Collaborator

@miguelvr miguelvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also take this opportunity and merge the types / functions?

I think they can exist in the enqueuer package and be imported by the operator

@deliahu
Copy link
Member Author

deliahu commented May 20, 2021

Can we also take this opportunity and merge the types / functions?

I think they can exist in the enqueuer package and be imported by the operator

As discussed live, we will address this in a separate PR

miguelvr
miguelvr approved these changes May 21, 2021
View reviewed changes
@deliahu deliahu merged commit 8226f42 into master May 22, 2021
@deliahu deliahu deleted the batch-job-submit-efficiency branch May 22, 2021 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelvr miguelvr miguelvr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Submitting a batch job with file_path_lister is failing/timing out
2 participants
@deliahu @miguelvr