Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AsyncAPI metrics dashboard #2242

Merged
merged 11 commits into from
Jun 11, 2021
Merged

AsyncAPI metrics dashboard #2242

merged 11 commits into from
Jun 11, 2021

Conversation

miguelvr
Copy link
Collaborator

@miguelvr miguelvr commented Jun 9, 2021

closes #1958

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)

RobertLucian
RobertLucian approved these changes Jun 10, 2021
View reviewed changes
Copy link
Member

@RobertLucian RobertLucian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@miguelvr miguelvr merged commit 0ac2d42 into master Jun 11, 2021
@miguelvr miguelvr deleted the async/metrics-collection branch June 11, 2021 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobertLucian RobertLucian RobertLucian approved these changes

@vishalbollu vishalbollu Awaiting requested review from vishalbollu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add metrics to AsyncAPI
2 participants
@miguelvr @RobertLucian