Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move statsd agent to a deployment on the operator nodegroup #2247

Merged
merged 6 commits into from
Jun 17, 2021
Merged

Move statsd agent to a deployment on the operator nodegroup #2247

merged 6 commits into from
Jun 17, 2021

Conversation

vishalbollu
Copy link
Contributor

@vishalbollu vishalbollu commented Jun 11, 2021 •
edited
Loading

closes #2041

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)

@vishalbollu vishalbollu changed the title Move statsd agent to a deployment on the operator Move statsd agent to a deployment on the operator nodegroup Jun 11, 2021
@miguelvr
Copy link
Collaborator

did you check this works (i.e. that you are able to write metrics to statsd)?

@vishalbollu vishalbollu merged commit 88b5507 into master Jun 17, 2021
@vishalbollu vishalbollu deleted the move-statsd-to-operator-nodegroup branch June 17, 2021 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deliahu deliahu deliahu approved these changes

@miguelvr miguelvr miguelvr approved these changes

@RobertLucian RobertLucian Awaiting requested review from RobertLucian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Metrics during a batch job are lost if the underlying instances are removed
4 participants
@vishalbollu @miguelvr @deliahu @RobertLucian