Skip to content

Load balancer doesn't obtain the endpoint when too many nodes are added on cluster-up #2338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 13, 2021
Merged

Load balancer doesn't obtain the endpoint when too many nodes are added on cluster-up #2338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
97df059
Limit # of nodes that can be added on cluster-up
RobertLucian Jul 13, 2021
5b7606f
Remove status port listener
RobertLucian Jul 13, 2021
4138755
Merge branch 'master' into fix/load-balancer-targets
RobertLucian Jul 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions manager/manifests/istio.yaml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,18 +55,12 @@ spec:
app: operator-istio-gateway
istio: ingressgateway-operator
ports:
- name: status-port # should be first in the list, see https://github.com/istio/istio/issues/12503
port: 15021
targetPort: 15021
- name: http2
port: 80
targetPort: 80
- name: https
port: 443
targetPort: 443
- name: tls # used for SNI
port: 15443
targetPort: 15443
resources:
requests:
cpu: 100m
Expand Down Expand Up @@ -114,18 +108,12 @@ spec:
app: apis-istio-gateway
istio: ingressgateway-apis
ports:
- name: status-port # should be first in the list, see https://github.com/istio/istio/issues/12503
port: 15021
targetPort: 15021
- name: http2
port: 80
targetPort: 80
- name: https
port: 443
targetPort: 443
- name: tls # used for SNI
port: 15443
targetPort: 15443
resources:
requests:
cpu: 400m
Expand Down
10 changes: 9 additions & 1 deletion pkg/types/clusterconfig/cluster_config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,16 @@ import (
const (
// MaxNodeGroups represents the max number of node groups in a cluster
MaxNodeGroups = 100

// MaxNodesToAddOnClusterUp represents the max number of nodes to add on cluster up
MaxNodesToAddOnClusterUp = 250
// Limited to 200 nodes (rounded down from 248 nodes) for two reasons:
//
// * To prevent overloading the API servers when the nodes are being added.
//
// * To prevent hitting the 500 targets per LB (when the cross-load balancing is enabled) limit (quota code L-B211E961);
// 500 divided by 2 target listeners - 1 operator node - 1 prometheus node => 248
MaxNodesToAddOnClusterUp = 200

// MaxNodesToAddOnClusterConfigure represents the max number of nodes to add on cluster up/configure
MaxNodesToAddOnClusterConfigure = 100
// ClusterNameTag is the tag used for storing a cluster's name in AWS resources
Expand Down