Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send all VPC CNI logs to /dev/null by default #2443

Merged
merged 1 commit into from
Sep 10, 2022

Conversation

RobertLucian
Copy link
Member

@RobertLucian RobertLucian commented Sep 9, 2022

Without this PR, the following lines would constantly get printed on screen when the cortex CLI is run:

2022-09-09 16:59:13.481063827 +0000 UTC m=+0.039526031 write error: can't make directories for new logfile: mkdir /host: permission denied
2022-09-09 16:59:13.481448123 +0000 UTC m=+0.039910297 write error: can't make directories for new logfile: mkdir /host: permission denied

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)

@RobertLucian RobertLucian added the bug Something isn't working label Sep 9, 2022
@RobertLucian RobertLucian requested a review from deliahu September 9, 2022 17:01
@RobertLucian RobertLucian self-assigned this Sep 9, 2022
@RobertLucian RobertLucian merged commit 51c18df into master Sep 10, 2022
@RobertLucian RobertLucian deleted the fix/logging-warning-error-from-vpc-cni branch September 10, 2022 00:12
@jshahbazi
Copy link

Just a heads-up: I'm still running into this in v0.42.1 on macOS. Setting the env variable as per the PR fixes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants