Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bart summarizer #907

Merged
merged 5 commits into from
Mar 27, 2020
Merged

Bart summarizer #907

merged 5 commits into from
Mar 27, 2020

Conversation

ismaelc
Copy link
Contributor

@ismaelc ismaelc commented Mar 24, 2020

closes #


checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)
  • update examples
  • update docs and add any new files to summary.md (view in gitbook after merging)
  • cherry-pick into release branches if applicable
  • alert the dev team if the dev environment changed

Sorry, something went wrong.

chris.ismael@sap.com and others added 2 commits March 24, 2020 15:15

Verified

This commit was signed with the committer’s verified signature.
tnull Elias Rohrer

Verified

This commit was signed with the committer’s verified signature.
tnull Elias Rohrer
@CLAassistant
Copy link

CLAassistant commented Mar 24, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ ismaelc
chris.ismael@sap.com


chris.ismael@sap.com seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Verified

This commit was signed with the committer’s verified signature.
tnull Elias Rohrer
@deliahu
Copy link
Member

deliahu commented Mar 25, 2020

@ismaelc thank you for your contribution, this is an awesome example!

@vishalbollu and I will review it soon; we're working on getting the next release out (hopefully tomorrow), and we'll take a look at this more carefully after

@deliahu deliahu added the v0.16 label Mar 25, 2020
@deliahu
Copy link
Member

deliahu commented Mar 27, 2020

@ismaelc I had a chance to look at this, and it's great! Thank you for sharing!

I decided to keep only the "new" summarizer (since on GPU it only takes ~1 second). Also, I felt like it should replace our existing text summarizer example, so I moved it to that directory.

@deliahu deliahu self-requested a review March 27, 2020 23:41
@deliahu deliahu merged commit 522f810 into cortexlabs:master Mar 27, 2020
@ismaelc
Copy link
Contributor Author

ismaelc commented Mar 28, 2020

@deliahu Awesome! Thank you

@ismaelc ismaelc deleted the bart-summarizer branch March 28, 2020 03:01
@deliahu deliahu added this to the v0.16 milestone Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants