Skip to content

adds volume configuration options #982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Apr 28, 2020
Merged

Conversation

tthebst
Copy link
Contributor

@tthebst tthebst commented Apr 26, 2020

closes #592


checklist:

  • [x ] run make test and make lint
  • [x ] test manually (i.e. build/push all images, restart operator, and re-deploy APIs)
  • update examples
  • [x ] update docs and add any new files to summary.md (view in gitbook after merging)
  • cherry-pick into release branches if applicable
  • [x ] alert the dev team if the dev environment changed

Copy link
Member

@deliahu deliahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tthebst This is awesome, great job! It's really great how you were able to figure out our conventions and where to put different parts of the code, that must have taken some additional effort, so thank you!

I added some comments, mostly minor. Let me know if you'd like to discuss any of them.

@deliahu
Copy link
Member

deliahu commented Apr 27, 2020

@tthebst Thanks for addressing my comments!

I merged master in, and made a few small updates to the branch.

I tried creating a cluster with io1 volume types, but it wasn't able to start up. Have you been able to create a cluster with io1 volumes?

I found this error message in my autoscaling group activity history:

Client.InvalidParameterCombination: Could not create volume with size 50GiB and iops 4000 from snapshot 'snap-05048ef88fd5fb0db'

Here's a screenshot:

Screen Shot 2020-04-27 at 4 41 42 PM

@deliahu
Copy link
Member

deliahu commented Apr 27, 2020

Update: I was able to reproduce the issue from the EBS console, and there was a better error message this time :)

image

I'll add a validation

Copy link
Member

@deliahu deliahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks again for your help on this!

Adding @vishalbollu for a quick review, and then I'll merge it in

@deliahu deliahu requested a review from vishalbollu April 28, 2020 00:36
@tthebst
Copy link
Contributor Author

tthebst commented Apr 28, 2020

@deliahu Sorry I didn't notice that there was a 50:1 ratio restriction

@deliahu deliahu merged commit 016461e into cortexlabs:master Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make worker node volume type and IOPS configurable
3 participants