Release 1.0.0 #227

nschad · 2021-09-22T18:35:45Z

Release 1.0.0

Allow overriding cortex Version
Update Policy API Version
Deprecate *.persistence
Remove clusterPort for alertmanager
Remove legacy alertmanager clustering
Removed unused nginx.serviceMonitor section
Added IngressClass to ingressResource
Update default values for bitnami memcached chart
Drop default chunk storage config (the chart still fully supports chunk storage if you so choose too)
server.grpc_server_max_recv_msg_size: 104857600 -> 10485760
server.grpc_server_max_send_msg_size: 104857600 -> 10485760
server.grpc_server_max_concurrent_streams: 1000 -> 10000
server.ingester_client.grpc_client_config.max_recv_msg_size: 104857600 -> 10485760
server.ingester_client.grpc_client_config.max_send_msg_size: 104857600 -> 10485760
config.limits.enforce_metric_name: false -> true
config.ruler.enable_api: false -> true
configure memberlist automatically
config.ingester.lifecycler.final_sleep: 0s -> 30s

Which issue(s) this PR fixes:
Fixes #202, #252

Checklist

CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

cabrinha · 2021-09-29T20:24:42Z

Let's also add the ability to deploy the config as a configMap rather than a secret?

nschad · 2021-09-29T20:45:20Z

Let's also add the ability to deploy the config as a configMap rather than a secret?

And have the credentials passed as environment variables backed by secrets? That would be quite optimal.

Chart.yaml

values.yaml

templates/alertmanager/alertmanager-dep.yaml

kd7lxl · 2021-10-01T15:54:18Z

values.yaml

+    - name: MEMCACHED_CACHE_SIZE
+      value: "1024"


This needs to correspond to the memory requests and limits. It shouldn't just arbitrarily be 1024 MB. It would be better to document how to do this than to hardcode it.

Yep it should also match with stuff like..

# CLI flag: -blocks-storage.bucket-store.index-cache.memcached.max-item-size [max_item_size: <int> | default = 1048576]

The CACHE_SIZE contains all the items, so it does not directly relate to max_item_size, other than having to be bigger than it to fit at least one item.

I've actually had a lot of issues figuring out which components of Cortex require what item sizes in the different caches. It'd be great if the Cortex documentation offered more clarity on what the max size an item could be, like an index, some metadata, or a block even.

The CACHE_SIZE contains all the items, so it does not directly relate to max_item_size, other than having to be bigger than it to fit at least one item.

Yep u right. Leaving this here for future reference: https://github.com/bitnami/bitnami-docker-memcached/blob/master/1/debian-10/rootfs/opt/bitnami/scripts/memcached/run.sh

I documented the helm values but we should have a Best-Practice wiki page on how to configure memcached properly with some (preferably) production experience. Doesn't have to be in this PR though

lahsivjar · 2021-10-04T17:02:18Z

Any ETA on 1.0.0 release? Is it possible to tag the current master? We have some fixes on the Memcache chart that we want to apply to our workload.

kd7lxl · 2021-10-04T17:12:16Z

@ShuzZzle, I'd recommend breaking up this PR so that it only contains the breaking changes. Before it's ready, we can release a minor version with non-breaking updates and new features.

Edit: never mind, I see this PR is already only the breaking changes. @lahsivjar comment threw me off because it's out of context. Sounds like they are requesting a minor version release (nothing to do with this PR).

nschad · 2021-10-04T17:24:01Z

Any ETA on 1.0.0 release? Is it possible to tag the current master? We have some fixes on the Memcache chart that we want to apply to our workload.

The same memcache fixxes in this PR or something similar?

lahsivjar · 2021-10-04T17:30:09Z

@kd7lxl @ShuzZzle Sorry for the confusion. I was not referring to this specific PR but releasing the current master with a minor tag. I need the changes done in liveliness probes in Memcached chart version 5.15.1. Should have opened a separate thread 😅

nschad · 2021-10-04T17:39:54Z

@kd7lxl @ShuzZzle Sorry for the confusion. I was not referring to this specific PR but releasing the current master with a minor tag. I need the changes done in liveliness probes in Memcached chart version 5.15.1. Should have opened a separate thread 😅

Sounds great, please do before we release a "buggy" version

Chart.yaml

templates/distributor/distributor-poddisruptionbudget.yaml

kd7lxl · 2021-11-23T16:03:06Z

templates/nginx/nginx-ingress.yaml

+{{- if .Values.ingress.ingressClass.enabled }}
+  ingressClassName: {{ .Values.ingress.ingressClass.name }}
+{{- end }}


The helm-boilerplate way of doing this (as close as we get to standards) is:
https://github.com/helm/helm/blob/d4cc130fa90027e8c1c69ad2a06c6dee4c31d29d/pkg/chartutil/create.go#L240-L242

Signed-off-by: ShuzZzle <niclas.schad@gmail.com>

…rride Signed-off-by: ShuzZzle <niclas.schad@gmail.com>

Signed-off-by: ShuzZzle <niclas.schad@gmail.com>

nschad marked this pull request as draft September 22, 2021 18:35

nschad mentioned this pull request Sep 23, 2021

policy/v1beta1 #202

Closed

nschad force-pushed the release-1.0.0 branch from 4debef2 to d1335df Compare September 28, 2021 07:19

kd7lxl reviewed Sep 30, 2021

View reviewed changes

Chart.yaml Outdated Show resolved Hide resolved

values.yaml Show resolved Hide resolved

templates/alertmanager/alertmanager-dep.yaml Outdated Show resolved Hide resolved

kd7lxl reviewed Oct 1, 2021

View reviewed changes

nschad force-pushed the release-1.0.0 branch from 9f12ed7 to 2e595fa Compare October 5, 2021 08:37

nschad marked this pull request as ready for review October 5, 2021 09:13

nschad mentioned this pull request Oct 5, 2021

Deploy the config as a configMap rather than a secret #235

Closed

kd7lxl reviewed Oct 5, 2021

View reviewed changes

Chart.yaml Show resolved Hide resolved

nschad force-pushed the release-1.0.0 branch from a4eb3cf to 456ab27 Compare October 6, 2021 08:08

nschad mentioned this pull request Oct 19, 2021

update default values.yaml #246

Closed

1 task

cabrinha requested review from cabrinha and kd7lxl October 26, 2021 17:00

kd7lxl reviewed Oct 26, 2021

View reviewed changes

templates/distributor/distributor-poddisruptionbudget.yaml Show resolved Hide resolved

cabrinha approved these changes Oct 27, 2021

View reviewed changes

nschad force-pushed the release-1.0.0 branch 2 times, most recently from ddd930a to 9f84719 Compare November 5, 2021 10:42

kd7lxl approved these changes Nov 5, 2021

View reviewed changes

nschad linked an issue Nov 17, 2021 that may be closed by this pull request

Tag 0.7.0 does not include PR 242 #252

Closed

nschad force-pushed the release-1.0.0 branch 2 times, most recently from bafd8a7 to cb48943 Compare November 21, 2021 10:58

kd7lxl reviewed Nov 23, 2021

View reviewed changes

jmcarp mentioned this pull request Nov 24, 2021

Reconcile kvstore recommendations #262

Closed

nschad mentioned this pull request Nov 24, 2021

Disable ingester liveness probes by default. #263

Merged

1 task

nschad added 20 commits November 25, 2021 11:12

prepare 1.0.0 release

b5d44c5

Signed-off-by: ShuzZzle <niclas.schad@gmail.com>

upgrade policy api version

d00eb56

Signed-off-by: ShuzZzle <niclas.schad@gmail.com>

bump version; use Chart.AppVersion instead of image.tag but allow ove…

247819a

…rride Signed-off-by: ShuzZzle <niclas.schad@gmail.com>

removed *.persistence in favor of *.persistentVolume

887f585

Signed-off-by: ShuzZzle <niclas.schad@gmail.com>

fix: cortex version

8f401b7

Signed-off-by: ShuzZzle <niclas.schad@gmail.com>

update readme

13b64cd

Signed-off-by: ShuzZzle <niclas.schad@gmail.com>

update values

b406f65

Signed-off-by: ShuzZzle <niclas.schad@gmail.com>

adjust memcached default settings

0179b6e

Signed-off-by: ShuzZzle <niclas.schad@gmail.com>

fix memcached serviceMonitor.enabled

dd61fa4

Signed-off-by: ShuzZzle <niclas.schad@gmail.com>

add documentation for memcached cache env vars

d56357f

Signed-off-by: ShuzZzle <niclas.schad@gmail.com>

replace if with scoped "with" statement

1f1c9e6

Signed-off-by: ShuzZzle <niclas.schad@gmail.com>

prepare changelog

20e204c

Signed-off-by: ShuzZzle <niclas.schad@gmail.com>

add ingressclass to ingress resource

b3f9e96

Signed-off-by: ShuzZzle <niclas.schad@gmail.com>

add sample for memcached and fix sidecar docs

5fe4416

Signed-off-by: ShuzZzle <niclas.schad@gmail.com>

remove nginx serviceMonitor

979a9e3

Signed-off-by: ShuzZzle <niclas.schad@gmail.com>

rework values

bc39cae

Signed-off-by: ShuzZzle <niclas.schad@gmail.com>

formatting and containerSecurityContext for sidecars

a03c171

Signed-off-by: ShuzZzle <niclas.schad@gmail.com>

disable ingressClass by default and fix NOTES.txt

97906c1

Signed-off-by: ShuzZzle <niclas.schad@gmail.com>

improve NOTES.txt

8663146

Signed-off-by: ShuzZzle <niclas.schad@gmail.com>

update README.md

6d7eefc

Signed-off-by: ShuzZzle <niclas.schad@gmail.com>

nschad force-pushed the release-1.0.0 branch from 2f13cfd to 6d7eefc Compare November 25, 2021 10:14

fix pdb for nginx

1f1160e

Signed-off-by: ShuzZzle <niclas.schad@gmail.com>

nschad force-pushed the release-1.0.0 branch from 592fc6e to 1f1160e Compare November 25, 2021 10:30

nschad added 3 commits November 25, 2021 12:37

finalize changelog

4a37b5d

Signed-off-by: ShuzZzle <niclas.schad@gmail.com>

cut 1.0.0 release

c8fa39f

Signed-off-by: ShuzZzle <niclas.schad@gmail.com>

add pr number to changelog

498977e

Signed-off-by: ShuzZzle <niclas.schad@gmail.com>

nschad merged commit ad6ebfd into cortexproject:master Nov 25, 2021

nschad deleted the release-1.0.0 branch November 25, 2021 11:54

kd7lxl mentioned this pull request Dec 1, 2021

workaround for .Capabilities.APIVersions #277

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 1.0.0 #227

Release 1.0.0 #227

nschad commented Sep 22, 2021 •

edited

Loading

cabrinha commented Sep 29, 2021

nschad commented Sep 29, 2021 •

edited

Loading

kd7lxl Oct 1, 2021

nschad Oct 1, 2021 •

edited

Loading

kd7lxl Oct 1, 2021 •

edited

Loading

cabrinha Oct 1, 2021

nschad Oct 2, 2021

nschad Oct 5, 2021 •

edited

Loading

lahsivjar commented Oct 4, 2021

kd7lxl commented Oct 4, 2021 •

edited

Loading

nschad commented Oct 4, 2021 •

edited

Loading

lahsivjar commented Oct 4, 2021 •

edited

Loading

nschad commented Oct 4, 2021

kd7lxl Nov 23, 2021

Release 1.0.0 #227

Release 1.0.0 #227

Conversation

nschad commented Sep 22, 2021 • edited Loading

Release 1.0.0

cabrinha commented Sep 29, 2021

nschad commented Sep 29, 2021 • edited Loading

kd7lxl Oct 1, 2021

Choose a reason for hiding this comment

nschad Oct 1, 2021 • edited Loading

Choose a reason for hiding this comment

kd7lxl Oct 1, 2021 • edited Loading

Choose a reason for hiding this comment

cabrinha Oct 1, 2021

Choose a reason for hiding this comment

nschad Oct 2, 2021

Choose a reason for hiding this comment

nschad Oct 5, 2021 • edited Loading

Choose a reason for hiding this comment

lahsivjar commented Oct 4, 2021

kd7lxl commented Oct 4, 2021 • edited Loading

nschad commented Oct 4, 2021 • edited Loading

lahsivjar commented Oct 4, 2021 • edited Loading

nschad commented Oct 4, 2021

kd7lxl Nov 23, 2021

Choose a reason for hiding this comment

nschad commented Sep 22, 2021 •

edited

Loading

nschad commented Sep 29, 2021 •

edited

Loading

nschad Oct 1, 2021 •

edited

Loading

kd7lxl Oct 1, 2021 •

edited

Loading

nschad Oct 5, 2021 •

edited

Loading

kd7lxl commented Oct 4, 2021 •

edited

Loading

nschad commented Oct 4, 2021 •

edited

Loading

lahsivjar commented Oct 4, 2021 •

edited

Loading