Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Helm release memcached to v6 #303

Merged
merged 3 commits into from
Dec 9, 2022
Merged

Update Helm release memcached to v6 #303

merged 3 commits into from
Dec 9, 2022

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 19, 2022 •
edited
Loading

Mend Renovate

This PR contains the following updates:

Package Update Change
memcached (source) major 5.15.14 -> 6.3.1

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Jan 19, 2022
@renovate renovate bot assigned kd7lxl and nschad Jan 19, 2022
@nschad
Copy link
Collaborator

nschad commented Jan 19, 2022

Commit: bitnami/charts@7b99d3b

@renovate renovate bot force-pushed the renovate/memcached-6.x branch 4 times, most recently from afccb62 to c85a668 Compare January 24, 2022 18:56
@renovate renovate bot force-pushed the renovate/memcached-6.x branch 6 times, most recently from 707dde4 to f73ea64 Compare February 2, 2022 22:53
@renovate renovate bot force-pushed the renovate/memcached-6.x branch 6 times, most recently from 4c41209 to 552eea0 Compare February 10, 2022 16:50
@renovate renovate bot force-pushed the renovate/memcached-6.x branch 3 times, most recently from dbfcede to db36552 Compare February 27, 2022 20:05
@renovate renovate bot force-pushed the renovate/memcached-6.x branch 4 times, most recently from 79bad8d to 69426fd Compare March 2, 2022 08:11
@renovate renovate bot force-pushed the renovate/memcached-6.x branch 3 times, most recently from cbf3374 to f01f8c1 Compare March 11, 2022 19:12
@renovate renovate bot force-pushed the renovate/memcached-6.x branch 2 times, most recently from 7a142e0 to 2c295b3 Compare October 5, 2022 08:16
@renovate renovate bot force-pushed the renovate/memcached-6.x branch 4 times, most recently from 29187f0 to c7b17ab Compare October 17, 2022 07:33
@holubales
Copy link

Hi, is there any plan when will this be merged? The current memcached version used contains quite a lot of critical security vulnerabilites (based on our scanning - mainly due to old debian version). Thank you!

@kd7lxl
Copy link
Collaborator

kd7lxl commented Oct 18, 2022

Hi, is there any plan when will this be merged? The current memcached version used contains quite a lot of critical security vulnerabilites (based on our scanning - mainly due to old debian version). Thank you!

I'm concerned that our CI might not be advanced enough to validate this major version upgrade. Would you mind testing this branch and reporting back?

@renovate renovate bot force-pushed the renovate/memcached-6.x branch 3 times, most recently from 6fb0d40 to 17b8ca0 Compare October 25, 2022 19:05
@renovate renovate bot force-pushed the renovate/memcached-6.x branch 2 times, most recently from f9205cf to 0f9bd67 Compare November 17, 2022 09:31
@nschad nschad added the help wanted Extra attention is needed label Nov 27, 2022
@renovate
Copy link
Contributor Author

renovate bot commented Dec 8, 2022

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.

⚠ Warning: custom changes will be lost.

renovate bot and others added 2 commits December 8, 2022 11:57
@renovate @nschad
Update Helm release memcached to v6
bee2718 
Signed-off-by: Renovate Bot <bot@renovateapp.com>
@nschad
rename extraEnvs to extraEnvVars in values.yml
0a99eaa 
Signed-off-by: Niclas Schad <niclas.schad@gmail.com>
@nschad
add CHANGELOG entry
6a27629 
Signed-off-by: Niclas Schad <niclas.schad@gmail.com>
@nschad nschad requested a review from kd7lxl December 8, 2022 11:01
kd7lxl
kd7lxl approved these changes Dec 8, 2022
View reviewed changes
README.md
@@ -432,51 +432,51 @@ Kubernetes: `^1.19.0-0`
| ingress.&ZeroWidthSpace;ingressClass.&ZeroWidthSpace;enabled | bool | `false` | |
| ingress.&ZeroWidthSpace;ingressClass.&ZeroWidthSpace;name | string | `"nginx"` | |
| ingress.&ZeroWidthSpace;tls | list | `[]` | |
| memcached | object | `{"architecture":"high-availability","enabled":false,"extraEnv":[{"name":"MEMCACHED_CACHE_SIZE","value":"1024"},{"name":"MEMCACHED_MAX_CONNECTIONS","value":"1024"},{"name":"MEMCACHED_THREADS","value":"4"}],"metrics":{"enabled":true,"serviceMonitor":{"enabled":false}},"replicaCount":2,"resources":{}}` | chunk caching for legacy chunk storage engine |
| memcached | object | `{"architecture":"high-availability","enabled":false,"extraEnvVars":[{"name":"MEMCACHED_CACHE_SIZE","value":"1024"},{"name":"MEMCACHED_MAX_CONNECTIONS","value":"1024"},{"name":"MEMCACHED_THREADS","value":"4"}],"metrics":{"enabled":true,"serviceMonitor":{"enabled":false}},"replicaCount":2,"resources":{}}` | chunk caching for legacy chunk storage engine |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is a breaking change for anyone using extraEnv. Probably a small set of people, if anybody, but we should do a major version bump after merging this regardless.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kd7lxl Good Point. I was going to do this anyway since we will drop chunk support with the next release (cortex 1.14)

@nschad nschad merged commit 85c54a9 into master Dec 9, 2022
@wynxel
Copy link

wynxel commented Dec 15, 2022

Hello, I am happy to see that this got merged. Do you already know when the release might happen? Thank you a lot!

@nschad
Copy link
Collaborator

nschad commented Dec 15, 2022

Hello, I am happy to see that this got merged. Do you already know when the release might happen? Thank you a lot!

next major release will be probably after #417 is merged

@nschad nschad mentioned this pull request Dec 15, 2022
Merged
1 task
SuperMatt pushed a commit to SuperMatt/cortex-helm-chart that referenced this pull request Jan 6, 2023
@renovate @nschad @SuperMatt
Update Helm release memcached to v6 (cortexproject#303)
95d72fb 
* Update Helm release memcached to v6

Signed-off-by: Renovate Bot <bot@renovateapp.com>

* rename extraEnvs to extraEnvVars in values.yml

Signed-off-by: Niclas Schad <niclas.schad@gmail.com>

* add CHANGELOG entry

Signed-off-by: Niclas Schad <niclas.schad@gmail.com>

Signed-off-by: Renovate Bot <bot@renovateapp.com>
Signed-off-by: Niclas Schad <niclas.schad@gmail.com>
Co-authored-by: Niclas Schad <niclas.schad@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nschad nschad nschad approved these changes

@kd7lxl kd7lxl kd7lxl approved these changes

Assignees

@kd7lxl kd7lxl

@nschad nschad

Labels
dependencies Pull requests that update a dependency file help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nschad @holubales @kd7lxl @wynxel