-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabled flags #319
Merged
Merged
Enabled flags #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luiz Oliveira <ziuloliveira@gmail.com>
Signed-off-by: Luiz Oliveira <ziuloliveira@gmail.com>
Signed-off-by: Luiz Oliveira <ziuloliveira@gmail.com>
Signed-off-by: Luiz Oliveira <ziuloliveira@gmail.com>
Signed-off-by: Luiz Oliveira <ziuloliveira@gmail.com>
Signed-off-by: Luiz Oliveira <ziuloliveira@gmail.com>
nschad
requested changes
Feb 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Please add a CHANGELOG entry
Signed-off-by: Luiz Oliveira <ziuloliveira@gmail.com>
Signed-off-by: Luiz Oliveira <ziuloliveira@gmail.com>
nschad
approved these changes
Feb 10, 2022
nschad
requested changes
Feb 11, 2022
nschad
approved these changes
Feb 13, 2022
Co-authored-by: Niclas Schad <niclas.schad@gmail.com> Signed-off-by: Luiz Oliveira <ziuloliveira@gmail.com>
I amended the last commit to include my signature, so the DCO bot stop failing. |
kd7lxl
approved these changes
Feb 23, 2022
Signed-off-by: nschad <niclas.schad@gmail.com>
nschad
reviewed
Feb 23, 2022
@@ -2,6 +2,8 @@ | |||
|
|||
## master / unreleased | |||
|
|||
* [ENHANCEMENT] Includes enable flags for each component #319 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooops missed that one :) but now it's correct.
elliottmb
added a commit
to elliottmb/cortex-helm-chart
that referenced
this pull request
Mar 13, 2022
elliottmb
added a commit
to elliottmb/cortex-helm-chart
that referenced
this pull request
Mar 13, 2022
Signed-off-by: elliottmb <2555214+elliottmb@users.noreply.github.com>
nschad
pushed a commit
that referenced
this pull request
Mar 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: Includes
enabled
flags for distributor, ingester, querier, query-frontend and store-gateway.Which issue(s) this PR fixes:
This PR enables the user to choose each part of the cortex gonna be released. Useful for situations where a namespace quota would request the cortex to be split into many namespaces.
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]