Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled flags #319

Merged
merged 11 commits into from
Feb 23, 2022
Merged

Enabled flags #319

merged 11 commits into from
Feb 23, 2022

Conversation

Ziul
Copy link
Contributor

@Ziul Ziul commented Feb 8, 2022

What this PR does: Includes enabled flags for distributor, ingester, querier, query-frontend and store-gateway.

Which issue(s) this PR fixes:
This PR enables the user to choose each part of the cortex gonna be released. Useful for situations where a namespace quota would request the cortex to be split into many namespaces.

Checklist

  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Luiz Oliveira <ziuloliveira@gmail.com>
Signed-off-by: Luiz Oliveira <ziuloliveira@gmail.com>
Signed-off-by: Luiz Oliveira <ziuloliveira@gmail.com>
Signed-off-by: Luiz Oliveira <ziuloliveira@gmail.com>
Signed-off-by: Luiz Oliveira <ziuloliveira@gmail.com>
Signed-off-by: Luiz Oliveira <ziuloliveira@gmail.com>
Copy link
Collaborator

@nschad nschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please add a CHANGELOG entry

templates/ingester/ingester-hpa.yaml Outdated Show resolved Hide resolved
templates/querier/querier-hpa.yaml Outdated Show resolved Hide resolved
Signed-off-by: Luiz Oliveira <ziuloliveira@gmail.com>
Signed-off-by: Luiz Oliveira <ziuloliveira@gmail.com>
@nschad nschad requested a review from kd7lxl February 10, 2022 23:42
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Niclas Schad <niclas.schad@gmail.com>
Signed-off-by: Luiz Oliveira <ziuloliveira@gmail.com>
@Ziul
Copy link
Contributor Author

Ziul commented Feb 15, 2022

I amended the last commit to include my signature, so the DCO bot stop failing.

Signed-off-by: nschad <niclas.schad@gmail.com>
@@ -2,6 +2,8 @@

## master / unreleased

* [ENHANCEMENT] Includes enable flags for each component #319
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops missed that one :) but now it's correct.

@nschad nschad merged commit ad2f5cf into cortexproject:master Feb 23, 2022
@Ziul Ziul deleted the enabled_flags branch February 25, 2022 19:13
@nschad nschad mentioned this pull request Mar 11, 2022
1 task
elliottmb added a commit to elliottmb/cortex-helm-chart that referenced this pull request Mar 13, 2022
@elliottmb elliottmb mentioned this pull request Mar 13, 2022
1 task
elliottmb added a commit to elliottmb/cortex-helm-chart that referenced this pull request Mar 13, 2022
Signed-off-by: elliottmb <2555214+elliottmb@users.noreply.github.com>
nschad pushed a commit that referenced this pull request Mar 13, 2022
* Fix typo introduced in #319

Signed-off-by: elliottmb <2555214+elliottmb@users.noreply.github.com>

* Update CHANGELOG.md

Signed-off-by: elliottmb <2555214+elliottmb@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants