Add Overrides-Exporter #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TaylorMutch
force-pushed
the
feat/overrides-exporter
branch
from
ed276b9
to
a04196b
Compare
nschad
requested changes
May 30, 2022
Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
Co-authored-by: Niclas Schad <niclas.schad@gmail.com> Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
Co-authored-by: Niclas Schad <niclas.schad@gmail.com> Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
Co-authored-by: Niclas Schad <niclas.schad@gmail.com> Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
TaylorMutch
force-pushed
the
feat/overrides-exporter
branch
from
a97e619
to
b78b24d
Compare
nschad
approved these changes
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Taylor Mutch taylormutch@gmail.com
What this PR does:
Adds opt-in support for deploying the Cortex overrides exporter. I followed the pattern from the
query-scheduler, and set the exporter to only run 1 pod (since its metrics should only be collected once for the cluster).Which issue(s) this PR fixes:
Fixes #359
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]