Start using autoscaling/v2 for HorizontalPodAutoscaler

[GuyKomari]

What this PR does / why we need it:

Problem: chart-testing is failing for:
"autoscaling/v2beta2 HorizontalPodAutoscaler is deprecated in v1.23+, unavailable in v1.26+; use autoscaling/v2"

https://github.com/cortexproject/cortex-helm-chart/actions/runs/3606103570/jobs/6077123598

Solution: update charts to start using autoscaler/v2

Signed-off-by: guykomari guykomari@gmail.com

[nschad]

We should do something like this until 1.26+. To keep functionality with older clusters.

{/*
Determine the policy api version
*/}}
{{- define "cortex.pdbVersion" -}}
{{- if or (.Capabilities.APIVersions.Has "policy/v1/PodDisruptionBudget") (semverCompare ">=1.21" .Capabilities.KubeVersion.Version) -}}
policy/v1
{{- else -}}
policy/v1beta1
{{- end -}}
{{- end -}}

[nschad]

Thank you, however please put the code in templates/_helpers.tpl global helpers file to avoid unnecessary code duplication just like with the pdbversion.

Then you can refer to it like this

apiVersion: {{ include "cortex.hpaVersion" . }}

On a side note: We should also check if something changed between v1beta1 and v1 (but I guess it shouldn't have?)

[GuyKomari]

Thank you, however please put the code in templates/_helpers.tpl global helpers file to avoid unnecessary code duplication just like with the pdbversion.

Then you can refer to it like this

apiVersion: {{ include "cortex.hpaVersion" . }}

On a side note: We should also check if something changed between v1beta1 and v1 (but I guess it shouldn't have?)

by the docs, it seems that nothing has changed.

[nschad]

Suggested change

	{{- if or (.Capabilities.APIVersions.Has "autoscaling/v2") (semverCompare ">=1.23" .Capabilities.KubeVersion.Version) -}}
	{{- if or (.Capabilities.APIVersions.Has "autoscaling/v2/HorizontalPodAutoscaler") (semverCompare ">=1.23" .Capabilities.KubeVersion.Version) -}}

Should be this

[nschad]

lgtm

[nschad]

@GuyKomari Check the Lint Test Job for error logs. There is some error evaluating the helm-chart.

Also please update the CHANGELOG.md

• CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

[GuyKomari]

@GuyKomari Check the Lint Test Job for error logs. There is some error evaluating the helm-chart.

Also please update the CHANGELOG.md

• CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

I ran the ct lint locally and it passes now, so the github action should pass now.

[GuyKomari]

@nschad once we merge this pr, when do u think we can also merge #413
and create a new release?

[kd7lxl]

LGTM, thank you!