Fix memcache dependency condition #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperMatt
force-pushed
the
fix-memcache-dependency-condition
branch
from
3ef8a29
to
31c6d0b
Compare
nschad
reviewed
Jan 6, 2023
nschad
approved these changes
Jan 6, 2023
There was a problem hiding this comment.
Verified. Thank you
@SuperMatt you need to fix your commits. Check the DCO Job in this PR for instructions
Signed-off-by: Matthew Ames <mames@yelp.com>
SuperMatt
force-pushed
the
fix-memcache-dependency-condition
branch
from
549fa8a
to
412b5a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: This change adds correct conditions for the memcache dependencies in the Chart.yaml file, and it also updates the Chart.lock file.
This change has been tested against my own test cluster, with both memcache enabled and disabled.
Which issue(s) this PR fixes:
Fixes #426
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]