Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add autoscaler for the ruler #430

Merged
merged 2 commits into from
Jan 26, 2023
Merged

add autoscaler for the ruler #430

merged 2 commits into from
Jan 26, 2023

Conversation

kd7lxl
Copy link
Collaborator

@kd7lxl kd7lxl commented Jan 25, 2023

What this PR does:
Defines an optional HorizontalPodAutoscaler for the ruler.

Requires a config like:

config:
  ruler:
    enable_sharding: true
    ring:
      kvstore:
        store: memberlist
ruler:
  autoscaling:
    enabled: true

as documented in https://cortexmetrics.io/docs/guides/ruler-sharding/.

Not sure if we should make any of these default or a condition on the HPA. Or maybe added a fail block to check for these conditions.

In my experience, both memory and CPU scale pretty linearly with ruler load, so I've included both as target metrics for the ruler HPA.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@kd7lxl kd7lxl requested a review from nschad January 25, 2023 17:47
Signed-off-by: Tom Hayward <thayward@infoblox.com>
Signed-off-by: Tom Hayward <thayward@infoblox.com>
@nschad nschad merged commit fdd21c4 into cortexproject:master Jan 26, 2023
@kd7lxl kd7lxl deleted the ruler-hpa branch January 26, 2023 17:19
@nschad nschad mentioned this pull request Mar 17, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants