Add annotations and labels to memberlist service #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Ames <mames@yelp.com>
SuperMatt
force-pushed
the
memberlist-service-annotations
branch
from
508ef16
to
35d4fac
Compare
kd7lxl
approved these changes
Feb 7, 2023
jmeza-xyz
pushed a commit
to jmeza-xyz/cortex-helm-chart
that referenced
this pull request
Mar 13, 2023
Signed-off-by: Matthew Ames <mames@yelp.com> Signed-off-by: John Meza <john.m.meza@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR allows for changes to the annotations and labels on the memberlist service. I'm looking for this to be added because I want a label to exclude the service from external-dns without our environment.
Which issue(s) this PR fixes:
n/a
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]