Add app protocol field #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkieweg
force-pushed
the
add-app-protocol-field
branch
from
fd212d7
to
04ab631
Compare
nschad
reviewed
Nov 28, 2023
nschad
requested changes
Dec 1, 2023
Signed-off-by: Manuel Kieweg <mkieweg@vectra.ai>
Signed-off-by: Manuel Kieweg <mkieweg@vectra.ai>
Signed-off-by: Manuel Kieweg <mkieweg@vectra.ai>
Co-authored-by: Niclas Schad <niclas.schad@gmail.com> Signed-off-by: Manuel Kieweg <mkieweg@vectra.ai>
mkieweg
force-pushed
the
add-app-protocol-field
branch
from
083eedf
to
ef718bc
Compare
nschad
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds the
appProtocolfield totemplates/svc-memberlist-headless.yaml. This makes the service compliant to the Istio specificationChecklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]