Send ddb region as awsCfg

cortexproject · Mar 29, 2024 · 327792f · 327792f
1 parent d0db754
commit 327792f
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/pkg/ring/kv/dynamodb/dynamodb.go b/pkg/ring/kv/dynamodb/dynamodb.go
@@ -57,13 +57,12 @@ func newDynamodbKV(cfg Config, logger log.Logger) (dynamodbKV, error) {
 		return dynamodbKV{}, err
 	}
 
+	awsCfg := aws.NewConfig()
 	if len(cfg.Region) > 0 {
-		sess.Config = &aws.Config{
-			Region: aws.String(cfg.Region),
-		}
+		awsCfg = awsCfg.WithRegion(cfg.Region)
 	}
 
-	dynamoDB := dynamodb.New(sess)
+	dynamoDB := dynamodb.New(sess, awsCfg)
 
 	ddbKV := &dynamodbKV{
 		ddbClient: dynamoDB,

diff --git a/pkg/ring/kv/dynamodb/dynamodb_test.go b/pkg/ring/kv/dynamodb/dynamodb_test.go
@@ -3,6 +3,7 @@ package dynamodb
 import (
 	"context"
 	"fmt"
+	util_log "github.com/cortexproject/cortex/pkg/util/log"
 	"strconv"
 	"testing"
 	"time"
@@ -28,6 +29,12 @@ func Test_TTLDisabled(t *testing.T) {
 
 }
 
+func Test_newDynamodbKV(t *testing.T) {
+	_, err := newDynamodbKV(Config{Region: "us-west-2", TableName: "TEST"}, util_log.Logger)
+
+	require.NoError(t, err)
+}
+
 func Test_TTL(t *testing.T) {
 	ddbClientMock := &mockDynamodb{
 		putItem: func(input *dynamodb.PutItemInput) *dynamodb.PutItemOutput {