-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to stop using deprecated grpc/naming
package
#2785
Comments
I'd like to pick this up. Any objections? Following the discussion in grpc/grpc#12295, the proposed fix seems to switch to a server side managed connection approach using As I understand the query frontend code this would break how frontends fan-out query processing to workers today. @bboreham is that a fair statement? If we want to stick to using polling we have to write our own dns watcher (or pull in the deleted code), or we adjust the interaction between the query frontend and the worker. |
This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions. |
Still valid. Required by future upgrade to gRPC 1.3.0. |
This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions. |
still valid |
This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions. |
Still valid |
Unblocked now that etcd-io/etcd#12709 has been merged |
This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions. |
We're not using the upstream |
It is gone from the latest gRPC release 1.30.
I found a notice announcing this: grpc/grpc-go#3180
Also interesting: why didn't the deprecated package raise a lint warning?
The text was updated successfully, but these errors were encountered: