Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update grpc dependency to 1.32. #12709

Merged
merged 1 commit into from
Feb 23, 2021
Merged

Conversation

ptabor
Copy link
Contributor

@ptabor ptabor commented Feb 22, 2021

Simplify grpc testing infrastructure to align with upstream changes.

Simplify grpc testing infrastructure to align with upstream changes.
@ptabor
Copy link
Contributor Author

ptabor commented Feb 23, 2021

I assume the PR is simple enough (just go.mod changes, and minor test adaptation), to merge without waiting for review.

@ptabor ptabor merged commit fa14a0a into etcd-io:master Feb 23, 2021
@ptabor ptabor deleted the 20210222-grpc1.32 branch February 23, 2021 11:19
@kprav33n
Copy link

kprav33n commented Feb 24, 2021

Thank you for this fix, @ptabor. I'm developing a project that uses grpc 1.32 (I don't want to downgrade) and etcd. What should I be putting in my go.mod in order to pick up this change from master? Can someone please give me an example?

I tried putting a replace directive like this:

replace go.etcd.io/etcd v3.3.25+incompatible => go.etcd.io/etcd fa14a0af89e6d2626c6803654c1535e2e7e71240

However, I see this error message during build.

go: errors parsing go.mod:
**REDACTED**/go.mod:17: replace go.etcd.io/etcd: version "v0.5.0-alpha.5.0.20210223111928-fa14a0af89e6" invalid: go.mod has post-v0 module path "go.etcd.io/etcd/v3" at revision fa14a0af89e6

Alternately, I also tried removing all etcd related entries from go.mod and run go get under my project's root. I still see the same error.

❯ go get go.etcd.io/etcd@fa14a0af89e6d2626c6803654c1535e2e7e71240
go get go.etcd.io/etcd@fa14a0af89e6d2626c6803654c1535e2e7e71240: go.etcd.io/etcd@v0.5.0-alpha.5.0.20210223111928-fa14a0af89e6: invalid version: go.mod has post-v0 module path "go.etcd.io/etcd/v3" at revision fa14a0af89e6

I also tried adding v3 suffix to etcd module path and it doesn't help either.

❯ go get go.etcd.io/etcd/v3@fa14a0af89e6d2626c6803654c1535e2e7e71240
go: go.etcd.io/etcd/v3 fa14a0af89e6d2626c6803654c1535e2e7e71240 => v3.3.0-rc.0.0.20210223111928-fa14a0af89e6
go get: go.etcd.io/etcd/v3@v3.3.0-rc.0.0.20210223111928-fa14a0af89e6 requires
        go.etcd.io/etcd/api/v3@v3.5.0-pre: reading go.etcd.io/etcd/api/api/go.mod at revision api/v3.5.0-pre: unknown revision api/v3.5.0-pre

@kprav33n
Copy link

For now, I have created a git submodule in my repo under submodules/etcd and pinned it to commit fa14a0a

I then used the replace directive to use etcd client from my local submodule.

require (
	...
	go.etcd.io/etcd/client/v3 v3.5.0-pre
	...
)

replace (
	go.etcd.io/etcd/api/v3 => ./submodules/etcd/api
	go.etcd.io/etcd/client/v3 => ./submodules/etcd/client/v3
	go.etcd.io/etcd/pkg/v3 => ./submodules/etcd/pkg
)

Maybe there is a cleaner approach than this. But, I'm able to make progress with this hack.

@coolbaluk
Copy link

Thanks for all your work on this :)

I also have the same question, what should I be putting in my go.mod file to get these changes ?

@ptabor
Copy link
Contributor Author

ptabor commented Mar 2, 2021

Now 3.5.0-alpha.0 got released.

so:

go get go.etcd.io/etcd/client/v3

or

go get go.etcd.io/etcd/client/v3@v3.5.0-alpha.0 

Should be all you need now. (without any 'replaces').

@chaochn47 chaochn47 mentioned this pull request Oct 13, 2023
24 tasks
chaochn47 added a commit to chaochn47/etcd that referenced this pull request Nov 22, 2023
…rors

Signed-off-by: Chao Chen <chaochn@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

grpc bump: Implement master/client/v3/naming new endpointManager & resolver
3 participants