Update dep: github.com/golang/protobuf v1.3.5 -> v1.5.1, grpc: 1.32->1.36 #12801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golang-proto runtime can deal with both: gogo & golang generated protobufs. It does not work vice-versa with protobuf-1.5.1.
ptabor
force-pushed
the
20210323-try-upgrade-proto
branch
from
d85ca9b
to
be59f98
Compare
ptabor
force-pushed
the
20210323-try-upgrade-proto
branch
from
be59f98
to
0dabcb4
Compare
ptabor
changed the title
ptabor
force-pushed
the
20210323-try-upgrade-proto
branch
from
0dabcb4
to
d0962f1
Compare
16 tasks
chaochn47
added a commit
to chaochn47/etcd
that referenced
this pull request
Nov 22, 2023
…rors Signed-off-by: Chao Chen <chaochn@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to https://go-review.googlesource.com/c/protobuf/+/300869/ its feasible now.
Huge kudos to: @dsnet and @justinsb