Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memcached client error message should include the cache name #4178

Closed
1 of 2 tasks
bboreham opened this issue May 12, 2021 · 1 comment
Closed
1 of 2 tasks

Memcached client error message should include the cache name #4178

bboreham opened this issue May 12, 2021 · 1 comment

Comments

@bboreham
Copy link
Contributor

Describe the bug
This error message doesn't say which cache was involved (index, metadata, chunks, etc.):

level=warn ts=2021-05-12T14:47:45.076049765Z caller=memcached_client.go:382 msg="failed to fetch items from memcached" numKeys=2535 firstKey=S:01F5FBARXPESQTKV2EH44JB0B3:28400064 err="read tcp 10.244.221.99:60966->10.244.222.6:11211: i/o timeout"

This was with Cortex v1.8.0.

Expected behavior
Add a tag like cache=index.

Storage Engine

  • Blocks
  • Chunks
@pracucci
Copy link
Contributor

This should have been fixed by thanos-io/thanos#3929 which has been vendored in #4102.

Closing for now, but let me know if it doesn't fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants