Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store: Adds the name of the instantiated memcached client to log info #3929

Merged
merged 4 commits into from
Apr 1, 2021
Merged

Store: Adds the name of the instantiated memcached client to log info #3929

merged 4 commits into from
Apr 1, 2021

Conversation

wiardvanrij
Copy link
Member

@wiardvanrij wiardvanrij commented Mar 13, 2021

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Relates to: #3667

Verification

Created a build but have not run e2e. Tested runtime of store.

Signed-off-by: Wiard van Rij <wiard@outlook.com>
@wiardvanrij wiardvanrij changed the title store: Adds the name of the instantiated memcached client to log info Store: Adds the name of the instantiated memcached client to log info Mar 13, 2021
Signed-off-by: Wiard van Rij <wiard@outlook.com>
Signed-off-by: Wiard van Rij <wiard@outlook.com>
Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (modulo a little suggestion)

pkg/cacheutil/memcached_client.go Outdated Show resolved Hide resolved
Signed-off-by: Wiard van Rij <wiard@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants