Skip to content

Compactor - skipping out-of-order blocks feature is disabled #4692

Closed
@shybbko

Description

@shybbko

There is a PR to introduce Thanos feature of skipping out of order blocks #4453. It was raised late August 2021 and has stayed open ever since.
However there was yet another PR raised later (I believe "later" being an important factor here), namely in October 2021 #4505 that got merged and introduced that feature, however hardcoded it to be disabled: https://github.com/cortexproject/cortex/blob/release-1.11/pkg/compactor/compactor.go#L660.

Why is that so? Is the code only partially ready for this feature to be enabled? What would be required in order for that feature to be enabled for Cortex? I believe there are at least several issues / people that would benefit from it (myself included).

Thanks.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions