-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Underpinnings of a better single-process, no-dependancies Cortex. #1127
Conversation
Also see weaveworks/common#132 |
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
This allows us to start Cortex on the Mac. Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
…entation as the ring does. Also, remove the two instances of KVClient mock hooks. Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Mostly looks like it's just moving the flags package to a new subdir and the updating the references. I'm a little concerned about Linux where the interface name is not one of the defaults. My linux systems have wlp2s0
in my laptop and enp2s0
on my desktop.
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
I've added the ability to override the interface names in yaml; don't want to put |
Starting to do the refactoring needed to build a better local/no-dependancies experience:
eth0
anden0
so Cortex will start on a Mac.