Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Underpinnings of a better single-process, no-dependancies Cortex. #1127

Merged
merged 8 commits into from
Dec 4, 2018

Conversation

tomwilkie
Copy link
Contributor

Starting to do the refactoring needed to build a better local/no-dependancies experience:

  • Move some flags code around, add ability to parse lists of strings, look for an address on both eth0 and en0 so Cortex will start on a Mac.
  • Start adding yaml tags to config structs; local config will need different sets of defaults for the flags, and instead of changing the defaults (which we can't do for backwards compat) I though we could load from form a yaml file?
  • Wire up the lifecycler code so it was use inmemory store, and make inmemory store "global" so the querier, ingester and distributor modules all get the same one.

@tomwilkie
Copy link
Contributor Author

Also see weaveworks/common#132

Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
This allows us to start Cortex on the Mac.

Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
…entation as the ring does.

Also, remove the two instances of KVClient mock hooks.

Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
Copy link
Contributor

@gouthamve gouthamve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Mostly looks like it's just moving the flags package to a new subdir and the updating the references. I'm a little concerned about Linux where the interface name is not one of the defaults. My linux systems have wlp2s0 in my laptop and enp2s0 on my desktop.

Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
@tomwilkie
Copy link
Contributor Author

I'm a little concerned about Linux where the interface name is not one of the defaults. My linux systems have wlp2s0 in my laptop and enp2s0 on my desktop.

I've added the ability to override the interface names in yaml; don't want to put lo in there as a hard coded default, but for the "local" config file we could include that.

@tomwilkie tomwilkie merged commit 5699ca2 into cortexproject:master Dec 4, 2018
@tomwilkie tomwilkie deleted the yaml branch December 4, 2018 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants