Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s3.buckets : allow spreading chunks across buckets #1625

Merged
merged 1 commit into from
Sep 12, 2019

Conversation

thorfour
Copy link
Contributor

s3 buckets have per bucket API limits, to circumvent hitting API limits we can spread chunks across buckets.

This PR introduces a new flag s3.buckets that takes a comma separated list of bucket names to spread chunks across.

@thorfour thorfour force-pushed the multi-s3 branch 2 times, most recently from 6dac32f to 1128fc3 Compare August 28, 2019 18:45
Copy link
Contributor

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm with one question

pkg/chunk/aws/dynamodb_storage_client.go Outdated Show resolved Hide resolved
pkg/chunk/aws/s3_storage_client.go Show resolved Hide resolved
@thorfour thorfour force-pushed the multi-s3 branch 2 times, most recently from ccc6c0e to 6b03b0f Compare September 12, 2019 15:41
Signed-off-by: Thor <thansen@digitalocean.com>
Copy link
Contributor

@csmarchbanks csmarchbanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@csmarchbanks csmarchbanks merged commit 4a7f5b0 into cortexproject:master Sep 12, 2019
@thorfour thorfour deleted the multi-s3 branch September 13, 2019 13:35
@khaines khaines mentioned this pull request Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants