Stop blocking batchTracker on chan when DoBatch() gets cancelled #1641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`batchTracker.record()` is written so there will only be one send on each chan, but if `ctx.Done()` happens before either then `DoBatch()` returns so we need 1 slot in each chan to be able to send without blocking when nobody is receiving. Signed-off-by: Bryan Boreham <bryan@weave.works>
bboreham
force-pushed
the
batch-chans
branch
from
b1a240b to
0052419
Compare
csmarchbanks
approved these changes
Sep 5, 2019
gouthamve
approved these changes
Sep 5, 2019
This was referenced Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1640
batchTracker.record()is written so there will only be one send on each chan, but ifctx.Done()happens before either thenDoBatch()returns so we need 1 slot in each chan to be able to send without blocking when nobody is receiving.