Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Cortex querier to use Queryable interface directly #2060

Merged
merged 15 commits into from
Feb 17, 2020
Merged

Refactor Cortex querier to use Queryable interface directly #2060

merged 15 commits into from
Feb 17, 2020

Commits on Feb 17, 2020

  1. New function now requires Queryable for store, instead of ChunkStore. 

    This makes it easier to use non-chunk-based queryables. On the other
hand, chunk-based queryables are still optimized in the way they were
before (in mergeSeriesSets).

Merged ingester_streaming_queryable.go into distributor_queryable.go.
Merged unified_querier.go into querier.go.

Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    15e32c6 View commit details
    Browse the repository at this point in the history

  2. Fix missing labels. 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    c6fda3e View commit details
    Browse the repository at this point in the history

  3. Removed unused method. 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    af4ec9a View commit details
    Browse the repository at this point in the history

  4. Added test for sorting series by partitionChunks. 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    b4bf3c2 View commit details
    Browse the repository at this point in the history

  5. Review feedback. 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    fd4601f View commit details
    Browse the repository at this point in the history

  6. Added comment about why series-requests are handled by distributor qu… 

    …erier.

Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    69f5ad1 View commit details
    Browse the repository at this point in the history

  7. Don't wait for results to arrive if context is done. 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    dfdc474 View commit details
    Browse the repository at this point in the history

  8. Don't call At() again for first series. 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    38a1dd3 View commit details
    Browse the repository at this point in the history

  9. More review feedback. 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    e826402 View commit details
    Browse the repository at this point in the history

  10. Added comment 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    1a80366 View commit details
    Browse the repository at this point in the history

  11. Improve comment. 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    f9328b9 View commit details
    Browse the repository at this point in the history

  12. Rename parameters to NewQueryable. 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    377fe7b View commit details
    Browse the repository at this point in the history

  13. Include empty set with error. Unify checks in seriesSetWithFirstSerie… 

    …s methods.

Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    594459c View commit details
    Browse the repository at this point in the history

  14. Fix imports ordering. 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    02146a3 View commit details
    Browse the repository at this point in the history

  15. Fix compactor test. 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    4161761 View commit details
    Browse the repository at this point in the history