Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set cassandra default reconnect interval to 1s #2687

Merged
merged 2 commits into from
Jun 4, 2020

Conversation

annanay25
Copy link
Contributor

Signed-off-by: Annanay annanayagarwal@gmail.com

What this PR does:
Sets the default reconnect interval to cassandra nodes to 1s

Which issue(s) this PR fixes:
Fixes NA

Checklist

  • NA Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Annanay <annanayagarwal@gmail.com>
Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please add an ENHANCEMENT changelog entry 🙏

Copy link
Contributor

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please add an ENHANCEMENT changelog entry 🙏

It also changes previous default value of cluster.ReconnectInterval. What was it? Should be documented in changelog.

Signed-off-by: Annanay <annanayagarwal@gmail.com>
@annanay25
Copy link
Contributor Author

Updated CHANGELOG.md. Thanks for the reviews!

@tomwilkie
Copy link
Contributor

(Don't think we need to wait for tests to pass for a changelog change).

@tomwilkie tomwilkie merged commit bcaa49d into cortexproject:master Jun 4, 2020
tomwilkie pushed a commit to grafana/cortex that referenced this pull request Jun 8, 2020
* Set cassandra default reconnect interval to 1s

Signed-off-by: Annanay <annanayagarwal@gmail.com>

* Update CHANGELOG

Signed-off-by: Annanay <annanayagarwal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants