Use intervalFn to support dynamic split interval in query frontend #3066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Ye <yb532204897@gmail.com>
6 tasks
pstibrany
approved these changes
Aug 24, 2020
| @@ -8,8 +8,10 @@ import ( | |||
| "github.com/prometheus/client_golang/prometheus/promauto" | |||
| ) | |||
|
|
|||
| type IntervalFn func(r Request) time.Duration | |||
There was a problem hiding this comment.
What are the requirements on this function? Can it really return different interval for each request? How will that interact with the caching?
There was a problem hiding this comment.
I'm curious about this as well. I'm happy to merge it, while we discuss this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ben Ye yb532204897@gmail.com
What this PR does:
This pr adds support for dynamic split interval based on the current request. This is useful in the Thanos downsampling use case.
For more details, please check thanos-io/thanos#1651.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]