Fail fast an ingester if unable to load existing TSDBs #3354
+84
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstibrany
approved these changes
Oct 19, 2020
pkg/ingester/ingester_v2.go
Outdated
| if err != nil { | ||
| level.Warn(util.Logger).Log("msg", "skipped filesystem entry when looking for existing TSDB to open", "path", path, "err", err) | ||
| return filepath.SkipDir |
There was a problem hiding this comment.
If there is any error traversing the tree, shouldn't we return such error? (Esp. if we're halting ingester if we fail to open TSDB)
There was a problem hiding this comment.
Yes, better to do error out. Done.
| @@ -1114,14 +1131,23 @@ func (i *Ingester) openExistingTSDB(ctx context.Context) error { | |||
| return filepath.SkipDir // Don't descend into directories | |||
| }) | |||
|
|
|||
| if walkErr != nil { | |||
There was a problem hiding this comment.
This cannot happen currently, since walkFn will filter out any error. (see other comment)
There was a problem hiding this comment.
Given I addressed the other comment, why can't happen? The Walk() interrupts and returns error as soon as we return error. Errors returned by Walk() itself are not filtered again via Walk().
There was a problem hiding this comment.
Even before it could, in case os.Open(path) or f.Readdirnames(1) failed.
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
force-pushed
the
fast-fail-ingester-if-unable-to-open-tsdb
branch
from
8e70495 to
1d67d44
Compare
pstibrany
approved these changes
Oct 19, 2020
| @@ -1114,14 +1131,23 @@ func (i *Ingester) openExistingTSDB(ctx context.Context) error { | |||
| return filepath.SkipDir // Don't descend into directories | |||
| }) | |||
|
|
|||
| if walkErr != nil { | |||
Signed-off-by: Marco Pracucci <marco@pracucci.com>
gotjosh
added a commit
to gotjosh/cortex
that referenced
this pull request
Oct 20, 2020
…rgid-ctx * 'master' of github.com:cortexproject/cortex: Enforce integration tests default flags config to never be overwritten (cortexproject#3370) Avoid deletion of blocks which are not shipped (cortexproject#3346) Upgrade Thanos to latest master (cortexproject#3363) Migrate CircleCI workflows to GitHub Actions (2/3) (cortexproject#3341) Remove comments that doesn't seem right (cortexproject#3361) add ingester interface (cortexproject#3352) Fail fast an ingester if unable to load existing TSDBs (cortexproject#3354) Fixed Gossip memberlist members joining when addresses are configured using DNS-based service discovery (cortexproject#3360) Export distributor method to get ingester replication set (cortexproject#3356) Correct link for Block Storage reference (cortexproject#3234) Added section on Cleaner. (cortexproject#3327) Update prometheus vendor to master (cortexproject#3345) adding GHA CI env variable check (cortexproject#3351) Add ingesters shuffle sharding support on the read path (cortexproject#3252)
This was referenced Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Tonight we had an issue in one ingester which had TSDB head chunks corrupted (root cause will be discussed separately). When a similar issue happen, the ingester skips the corrupted TSDB at startup, it joins the ring with
ACTIVEstate and, as soon as receive any write request from the tenant with the corrupted TSDB it will try to reopen the TSDB for every single write request. This leads to an undesirable situation, which will soon get the ingester to get killed (due to OOM).In this PR I'm proposing to fail fast the ingester if unable to load an existing TSDB. It's a loud and clear signal to the Cortex cluster operator and, in my opinion, it's better to fail fast an ingester before it start receiving write requests instead of having it failing few minutes after running.
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]