Fail ingestion when a flush is going on #3422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
codesome
force-pushed
the
fix-flush-race
branch
from
5a9f1b0 to
68126ab
Compare
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
pracucci
approved these changes
Oct 30, 2020
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
ranton256
reviewed
Oct 30, 2020
|
@pstibrany Me and @codesome are discussion a potentially better way to handle this. Please don't merge it you approve it. |
@pstibrany Ignore this. After further discussion, Ganesh has no bandwidth to experiment alternative solutions (eg. disable blocks compaction at all in TSDB and enable overlapping blocks in TSB, making sure query performances don't degrade significantly on overlapping blocks), so I think we can get this PR in and then we may reconsider this approach if/when Ganesh will have bandwidth. So we can merge if you approve, but let's wait for Ganesh adding the test suggested by Richard first. |
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
pracucci
approved these changes
Nov 3, 2020
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
pstibrany
approved these changes
Nov 3, 2020
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Fails a push request with a 5xx when there is an ongoing flush. This is according to the idea proposed in this comment #3282 (comment)
Which issue(s) this PR fixes:
Fixes #3282 #3348
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]