Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Thanos to fix GCS/COS recursive bucket.Iter() and S3 KMS encryption context #3886

Merged
merged 1 commit into from
Feb 26, 2021

Conversation

pracucci
Copy link
Contributor

What this PR does:
This PR upgrades Thanos to bring in a couple of fixes:

  1. The recursive bucket.Iter() was buggy for GCS/COS backends (fix: Add objstore.List() recursive support thanos-io/thanos#3823)
  2. Minio upgrade which fixes, among other things, S3 KMS encryption context header (fix: encrypt: fix SSE-KMS HTTP context header minio/minio-go#1430)

Which issue(s) this PR fixes:
N/A

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

…yption context

Signed-off-by: Marco Pracucci <marco@pracucci.com>
Copy link
Contributor

@jtlisi jtlisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pracucci pracucci merged commit 90108ce into cortexproject:master Feb 26, 2021
@pracucci pracucci deleted the upgrade-thanos branch February 26, 2021 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants