Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable block deletion marks migration by default #4597

Merged
merged 2 commits into from
Jan 6, 2022
Merged

Conversation

bboreham
Copy link
Contributor

This feature was added in v1.7, so we expect most users to have upgraded by now.
If you leave it on it causes delay and some IO cost when starting compactors.
Flag is named -compactor.block-deletion-marks-migration-enabled.

  • NA Tests updated
  • Documentation added
  • CHANGELOG.md updated

Flag is named `-compactor.block-deletion-marks-migration-enabled`.
This feature was added in v1.7, so we expect most users to have upgraded
by now.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
@bboreham bboreham merged commit 380af11 into master Jan 6, 2022
@bboreham bboreham deleted the del-mig-off branch January 6, 2022 13:43
alvinlin123 pushed a commit to ac1214/cortex that referenced this pull request Jan 14, 2022
* Disable block deletion marks migration by default

Flag is named `-compactor.block-deletion-marks-migration-enabled`.
This feature was added in v1.7, so we expect most users to have upgraded
by now.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
Signed-off-by: Alvin Lin <alvinlin@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants