Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce ring/kv/* packages #4611

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

aknuds1
Copy link
Contributor

@aknuds1 aknuds1 commented Jan 12, 2022

What this PR does:
Reintroduce ring/kv/* packages, in place of grafana/dskit/kv/* packages. I've copied the current kv code from dskit.

Which issue(s) this PR fixes:

Checklist

  • Tests updated
  • [na] Documentation added
  • [na] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@aknuds1 aknuds1 changed the title WIP: Reintroduce ring/kv/* packages Reintroduce ring/kv/* packages Jan 13, 2022
@aknuds1 aknuds1 marked this pull request as ready for review January 13, 2022 09:24
@aknuds1 aknuds1 force-pushed the chore/reintroduce-kv branch 2 times, most recently from 79ece1a to f2cc5db Compare January 13, 2022 09:45
Copy link
Contributor

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

)"

This reverts commit 32b1b40.

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pracucci pracucci enabled auto-merge (squash) January 13, 2022 14:28
@pracucci pracucci merged commit 0775e2d into cortexproject:master Jan 13, 2022
alvinlin123 pushed a commit to ac1214/cortex that referenced this pull request Jan 14, 2022
)" (cortexproject#4611)

This reverts commit 32b1b40.

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Signed-off-by: Alvin Lin <alvinlin@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants