-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix opsgenie validation #5045
Merged
Merged
Fix opsgenie validation #5045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
friedrichg
commented
Dec 16, 2022
friedrichg
force-pushed
the
fix-opsgenie-validation
branch
from
December 16, 2022 12:57
dc639c7
to
6e986a5
Compare
yeya24
approved these changes
Dec 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix!
alanprot
approved these changes
Dec 16, 2022
Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com>
Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com>
Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com>
Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com>
friedrichg
force-pushed
the
fix-opsgenie-validation
branch
from
December 16, 2022 17:46
6e986a5
to
8f05382
Compare
alanprot
pushed a commit
that referenced
this pull request
Dec 18, 2022
* Validate OpsGenie alertmanager configuration Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com> * Update changelog Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com> * Validate global config too Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com> * fix pr number in changelog Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com> Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com>
alanprot
pushed a commit
that referenced
this pull request
Dec 18, 2022
* Validate OpsGenie alertmanager configuration Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com> * Update changelog Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com> * Validate global config too Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com> * fix pr number in changelog Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com> Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com>
alanprot
pushed a commit
that referenced
this pull request
Dec 18, 2022
* Validate OpsGenie alertmanager configuration Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com> * Update changelog Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com> * Validate global config too Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com> * fix pr number in changelog Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com> Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com> Signed-off-by: Alan Protasio <approtas@amazon.com>
alanprot
pushed a commit
that referenced
this pull request
Dec 18, 2022
* Validate OpsGenie alertmanager configuration Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com> * Update changelog Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com> * Validate global config too Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com> * fix pr number in changelog Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com> Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com> Signed-off-by: Alan Protasio <approtas@amazon.com>
alanprot
pushed a commit
that referenced
this pull request
Dec 18, 2022
* Validate OpsGenie alertmanager configuration Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com> * Update changelog Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com> * Validate global config too Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com> * fix pr number in changelog Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com> Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com> Signed-off-by: Alan Protasio <approtas@amazon.com> Signed-off-by: Alan Protasio <alanprot@gmail.com>
alanprot
pushed a commit
that referenced
this pull request
Dec 18, 2022
* Validate OpsGenie alertmanager configuration Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com> * Update changelog Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com> * Validate global config too Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com> * fix pr number in changelog Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com> Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com> Signed-off-by: Alan Protasio <alanprot@gmail.com>
alanprot
pushed a commit
that referenced
this pull request
Dec 18, 2022
* Validate OpsGenie alertmanager configuration Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com> * Update changelog Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com> * Validate global config too Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com> * fix pr number in changelog Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com> Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com>
alanprot
pushed a commit
that referenced
this pull request
Dec 18, 2022
* Validate OpsGenie alertmanager configuration Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com> * Update changelog Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com> * Validate global config too Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com> * fix pr number in changelog Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com> Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com> Signed-off-by: Alan Protasio <alanprot@gmail.com>
alexqyle
pushed a commit
to alexqyle/cortex
that referenced
this pull request
May 2, 2023
* Validate OpsGenie alertmanager configuration Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com> * Update changelog Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com> * Validate global config too Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com> * fix pr number in changelog Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com> Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com> Signed-off-by: Alex Le <leqiyue@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: Fix opsgenie validation
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]