Fix sorted queries do not produce sorted results for shardable queries #5148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 🌲 Harry 🌊 John 🏔 <johrry@amazon.com>
Signed-off-by: 🌲 Harry 🌊 John 🏔 <johrry@amazon.com>
harry671003
changed the title
Signed-off-by: 🌲 Harry 🌊 John 🏔 <johrry@amazon.com>
yeya24
approved these changes
Feb 15, 2023
alanprot
approved these changes
Feb 15, 2023
|
It would be nice to have this on Thanos as well so we are sure both projects has the same solution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR addresses a bug in query vertical sharding where the merged result doesn't sort the series by sample value for
sort()andsort_desc()functions.Which issue(s) this PR fixes:
Fixes: thanos-io/thanos#6059
Thanos PR: thanos-io/thanos#6125
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]