log query response size in QFE and querier #5288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Ye <benye@amazon.com> enable response size message in processor Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: Ben Ye <benye@amazon.com>
friedrichg
approved these changes
Apr 25, 2023
yeya24
changed the title
Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: Ben Ye <benye@amazon.com>
alanprot
approved these changes
Apr 25, 2023
yeya24
added a commit
to yeya24/cortex
that referenced
this pull request
Apr 28, 2023
* log final query response size in QFE Signed-off-by: Ben Ye <benye@amazon.com> enable response size message in processor Signed-off-by: Ben Ye <benye@amazon.com> * fix import Signed-off-by: Ben Ye <benye@amazon.com> * remove the response size counter metric Signed-off-by: Ben Ye <benye@amazon.com> * update content encoding log Signed-off-by: Ben Ye <benye@amazon.com> --------- Signed-off-by: Ben Ye <benye@amazon.com>
alexqyle
pushed a commit
to alexqyle/cortex
that referenced
this pull request
May 2, 2023
* log final query response size in QFE Signed-off-by: Ben Ye <benye@amazon.com> enable response size message in processor Signed-off-by: Ben Ye <benye@amazon.com> * fix import Signed-off-by: Ben Ye <benye@amazon.com> * remove the response size counter metric Signed-off-by: Ben Ye <benye@amazon.com> * update content encoding log Signed-off-by: Ben Ye <benye@amazon.com> --------- Signed-off-by: Ben Ye <benye@amazon.com> Signed-off-by: Alex Le <leqiyue@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Log query response size in query frontend query stats log.
Also I added a line of log to log the response size and http status code in querier. This is helpful to track whether a user's response has went beyond the max response body size.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]