-
Notifications
You must be signed in to change notification settings - Fork 817
Add codeql workflow #5743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add codeql workflow #5743
Conversation
3549dcd
to
b5eac60
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @Kramer0x0 , just one small nit.
.github/workflows-doc.md
Outdated
@@ -19,6 +19,7 @@ test-build-deploy.yml specifies a workflow that runs all Cortex continuous integ | |||
| test | Runs units tests on Cassandra testing framework. | CI | | |||
| integration-configs-db | Integration tests for database configurations. | CI | | |||
| integration | Runs integration tests after upgrading golang, pulling necessary docker images and downloading necessary module dependencies. | CI | | |||
| Security/CodeQL | CodeQL is a semantic code analysis engine used for automating security checks, enabling developers to write and run queries to identify vulnerabilities and improve code security | CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we format it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally! Sorry about that :)
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Signed-off-by: Ryan West <rwest2@apple.com>
Signed-off-by: Ryan West <rwest2@apple.com>
Signed-off-by: Ryan West <rwest2@apple.com>
Signed-off-by: Ryan West <rwest2@apple.com>
Signed-off-by: Ryan West <rwest2@apple.com>
69b77d0
to
26269c4
Compare
Thanks! |
Seems the CodeQL is breaking in master: https://github.com/cortexproject/cortex/actions/runs/7747719874/job/21162892320 |
What this PR does:
This pull request integrates CodeQL, an Open Source semantic code analysis tool, into the upstream repository's workflow. By incorporating CodeQL, it enhances the repository's security posture by automatically detecting vulnerabilities and coding errors during the development process. This addition will ensure continuous and automated code quality checks, significantly improving the overall security and maintainability of the codebase.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]