Overwriting permissions on security related jobs #5762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan West <rwest2@apple.com>
|
cc: @alanprot |
|
Thanks! |
alanprot
approved these changes
Feb 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
CodeQL is breaking in master branch because of the following errors:
Error: Resource not accessible by integration. This PR adds the appropriate permissions for the job to be able to submit back to the security tab under the master branch. Our permission set isread-onlyby default, this overrides that specific behavior for this particular "Security" related job.Looking at the job's setup - the security events is set to read, I believe this should be set to "Write". This is also why I believe it's not reporting the status to the Security Tab.
Which issue(s) this PR fixes:
Fixes #5761
Related Issue:
github/codeql#8843
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]